Update icon logic #525
Open
Update icon logic #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeninski
reviewed
Oct 25, 2022
|
@BogdanW3 Can you explain again what problem this solves? Is there an example of the issue? |
This commit was made over two years ago now, the idea was to change up the icon logic to make it more reasonable, but that included some decisions as well. Believe that I have no recollection of the specifics anymore, but something along these lines might still be favourable to pursue, when we figure out what it was. Re-checking the commit, it was potentially about no longer handing special icons completely separately from others (race icons and starters) and multiple small bugfixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rankings and CountryRankings still used the old logic, where TOTAL icons were fallbacks. Now only if there is no selected icon record will a calculated race be used